add Create(), Delete() in TfJobClient interface, rename tpr_util.go t…

…o tf_job_client.go (#152) Add routines to make the go client more complete. Rename a poorly named file.
kubeflow · Nov 16, 2017 · db5c875 · db5c875
1 parent 397ef28
commit db5c875
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/pkg/util/k8sutil/fake/fake.go b/pkg/util/k8sutil/fake/fake.go
@@ -13,6 +13,14 @@ func (c *TfJobClientFake) Get(ns string, name string) (*spec.TfJob, error) {
 	return &spec.TfJob{}, nil
 }
 
+func (c *TfJobClientFake) Create(ns string, j *spec.TfJob) (*spec.TfJob, error) {
+	return &spec.TfJob{}, nil
+}
+
+func (c *TfJobClientFake) Delete(ns string, name string) error {
+	return nil
+}
+
 func (c *TfJobClientFake) List(ns string) (*spec.TfJobList, error) {
 	return &spec.TfJobList{}, nil
 }

diff --git a/pkg/util/k8sutil/tpr_util.go → pkg/util/k8sutil/tf_job_client.go b/pkg/util/k8sutil/tpr_util.go → pkg/util/k8sutil/tf_job_client.go
@@ -12,8 +12,6 @@
 
 package k8sutil
 
-// TODO(jlewi): We should rename this file to reflect the fact that we are using CRDs and not TPRs.
-
 import (
 	"encoding/json"
 	"fmt"
@@ -34,6 +32,12 @@ type TfJobClient interface {
 	// Get returns a TfJob
 	Get(ns string, name string) (*spec.TfJob, error)
 
+	// Create a TfJob
+	Create(ns string, j *spec.TfJob) (*spec.TfJob, error)
+
+	// Delete a TfJob
+	Delete(ns string, name string) error
+
 	// List returns a list of TfJobs
 	List(ns string) (*spec.TfJobList, error)