Rename lora to peft config

Signed-off-by: Andrey Velichkevich <[email protected]>
kubeflow · Nov 26, 2024 · cc3be21 · cc3be21
1 parent b8a22c3
commit cc3be21
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/sdk_v2/kubeflow/training/api/training_client.py b/sdk_v2/kubeflow/training/api/training_client.py
@@ -211,10 +211,10 @@ def train(
         if (
             trainer
             and trainer.fine_tuning_config
-            and trainer.fine_tuning_config.lora_config
+            and trainer.fine_tuning_config.peft_config
         ):
             trainer_crd.env = utils.get_lora_config(
-                trainer.fine_tuning_config.lora_config
+                trainer.fine_tuning_config.peft_config
             )
 
         train_job = models.KubeflowOrgV2alpha1TrainJob(

diff --git a/sdk_v2/kubeflow/training/types/types.py b/sdk_v2/kubeflow/training/types/types.py
@@ -61,7 +61,8 @@ class LoraConfig:
 
 @dataclass
 class FineTuningConfig:
-    lora_config: Optional[LoraConfig] = None
+    # TODO (andreyvelich): Add more configs once we support them, e.g. QLoRA.
+    peft_config: Optional[LoraConfig] = None
 
 
 # Configuration for the Trainer.