Skip to content

Commit

Permalink
Trim down CRD descriptions
Browse files Browse the repository at this point in the history
Trim down CRD descriptions to avoid the following apply errors:

```
The CustomResourceDefinition "pytorchjobs.kubeflow.org" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
```
  • Loading branch information
tenzen-y committed Jan 21, 2023
1 parent e6b4300 commit 92b05c5
Show file tree
Hide file tree
Showing 7 changed files with 1,171 additions and 5,739 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Image URL to use all building/pushing image targets
IMG ?= kubeflow/training-operator:latest
# CRD generation options
CRD_OPTIONS ?= "crd:generateEmbeddedObjectMeta=true"
CRD_OPTIONS ?= "crd:generateEmbeddedObjectMeta=true,maxDescLen=300"

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
Expand Down
1,146 changes: 194 additions & 952 deletions manifests/base/crds/kubeflow.org_mpijobs.yaml

Large diffs are not rendered by default.

1,146 changes: 194 additions & 952 deletions manifests/base/crds/kubeflow.org_mxjobs.yaml

Large diffs are not rendered by default.

1,162 changes: 197 additions & 965 deletions manifests/base/crds/kubeflow.org_paddlejobs.yaml

Large diffs are not rendered by default.

1,162 changes: 197 additions & 965 deletions manifests/base/crds/kubeflow.org_pytorchjobs.yaml

Large diffs are not rendered by default.

1,146 changes: 194 additions & 952 deletions manifests/base/crds/kubeflow.org_tfjobs.yaml

Large diffs are not rendered by default.

1,146 changes: 194 additions & 952 deletions manifests/base/crds/kubeflow.org_xgboostjobs.yaml

Large diffs are not rendered by default.

0 comments on commit 92b05c5

Please sign in to comment.