testutil: Fix linting errors

Signed-off-by: Ce Gao <[email protected]>
kubeflow · Jun 15, 2018 · 224ad6f · 224ad6f
1 parent 15453bf
commit 224ad6f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/util/testutil/pod.go b/pkg/util/testutil/pod.go
@@ -27,8 +27,6 @@ import (
 )
 
 const (
-	controllerName = "tf-operator"
-
 	// labels for pods and servers.
 	tfReplicaTypeLabel  = "tf-replica-type"
 	tfReplicaIndexLabel = "tf-replica-index"

diff --git a/pkg/util/testutil/service.go b/pkg/util/testutil/service.go
@@ -56,6 +56,8 @@ func NewServiceList(count int32, tfJob *tfv1alpha2.TFJob, typ string, t *testing
 
 func SetServices(serviceIndexer cache.Indexer, tfJob *tfv1alpha2.TFJob, typ string, activeWorkerServices int32, t *testing.T) {
 	for _, service := range NewServiceList(activeWorkerServices, tfJob, typ, t) {
-		serviceIndexer.Add(service)
+		if err := serviceIndexer.Add(service); err != nil {
+			t.Errorf("unexpected error when adding service %v", err)
+		}
 	}
 }