Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpate quick start for tfjobs #952

Merged
merged 1 commit into from
Mar 12, 2019
Merged

udpate quick start for tfjobs #952

merged 1 commit into from
Mar 12, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Mar 6, 2019

The quick start for tfjobs is out of date, The current versions of the TF operator is v1beta1, but the quick start is still for v1alpha2, that cannot be executed in kubeflow 0.4, and some link is not reasonable.

The PR is to update the quick start for v1beta1, and correct a link and sample outputs. Thanks.


This change is Reviewable

@jinchihe
Copy link
Member Author

jinchihe commented Mar 6, 2019

/assign @ScorpioCPH

@coveralls
Copy link

coveralls commented Mar 6, 2019

Coverage Status

Coverage remained the same at 76.744% when pulling 3763202 on jinchihe:udpate_quick_start_for_tf into 6f74850 on kubeflow:master.

@jinchihe
Copy link
Member Author

jinchihe commented Mar 8, 2019

/assign @gaocegege

Could you please take a look or assign someone? Thanks.

@johnugeorge
Copy link
Member

Current version is v1beta2 and v1beta1 configs are also supported. I see that v1beta2 examples are not added though.
Related: #943

@jinchihe
Copy link
Member Author

Current version is v1beta2 and v1beta1 configs are also supported. I see that v1beta2 examples are not added though.
Related: #943

Thanks @johnugeorge, I updated the quick start to mention v1beta2. But I think we can just show v1beta1 as previous behavior, since just have example for v1beta1 under examples. Comments?

@johnugeorge
Copy link
Member

Sounds good

@johnugeorge
Copy link
Member

/retest

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 81187c4 into kubeflow:master Mar 12, 2019
@jinchihe jinchihe deleted the udpate_quick_start_for_tf branch March 12, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants