-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
udpate quick start for tfjobs #952
udpate quick start for tfjobs #952
Conversation
/assign @ScorpioCPH |
/assign @gaocegege Could you please take a look or assign someone? Thanks. |
Current version is v1beta2 and v1beta1 configs are also supported. I see that v1beta2 examples are not added though. |
Thanks @johnugeorge, I updated the quick start to mention v1beta2. But I think we can just show v1beta1 as previous behavior, since just have example for v1beta1 under examples. Comments? |
Sounds good |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The quick start for tfjobs is out of date, The current versions of the TF operator is v1beta1, but the quick start is still for v1alpha2, that cannot be executed in kubeflow 0.4, and some link is not reasonable.
The PR is to update the quick start for v1beta1, and correct a link and sample outputs. Thanks.
This change is