Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tf-operator presubmit failures by installing go manually #885

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Dec 5, 2018

Presubmits were failing due to Go installation error:

Step 2/15 : ENV GOLANG_VERSION 1.8.3
---> Running in b613b7584fbe
Removing intermediate container b613b7584fbe
---> 966d561c20b7
Step 3/15 : RUN yum -y install go && yum clean all
---> Running in 3e92d32ce757
Loaded plugins: fastestmirror, ovl
Determining fastest mirrors
* base: mirrors.ocf.berkeley.edu
* extras: mirrors.ocf.berkeley.edu
* updates: mirror.sjc02.svwh.net
No package go available.
Error: Nothing to do
The command '/bin/sh -c yum -y install go && yum clean all' returned a non-zero code: 1
ERROR
ERROR: build step 0 "gcr.io/cloud-builders/docker" failed: exit status 1

Fix is to install Go (same version) manually.

This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @lluunn

@richardsliu
Copy link
Contributor Author

/assign @johnugeorge

@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardsliu richardsliu merged commit 4ec6be0 into kubeflow:master Dec 5, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.79% when pulling 9e153e4 on richardsliu:fix_presubmit into 4b54d94 on kubeflow:master.

@richardsliu richardsliu deleted the fix_presubmit branch March 4, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants