Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopkg: Use version instead of branch #872

Merged
merged 2 commits into from
Nov 19, 2018
Merged

gopkg: Use version instead of branch #872

merged 2 commits into from
Nov 19, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Nov 19, 2018

Ref https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md#version

Note: When you specify a version without an operator, dep automatically uses the ^ operator by default. dep ensure will interpret the given version as the min-boundary of a range.

Using version allows us to be compatible with more versions.

/hold

/cc @zjj2wry @codeflitting Does it work for you?

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@gaocegege
Copy link
Member Author

/assign @zjj2wry

Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage remained the same at 64.496% when pulling c843614 on gaocegege:1.10 into 3a0efc1 on kubeflow:master.

@gaocegege
Copy link
Member Author

/retest

@zjj2wry
Copy link
Member

zjj2wry commented Nov 19, 2018

branches may change all the time, using version ensures that the code for dep ensure is consistent.
/lgtm

@zjj2wry
Copy link
Member

zjj2wry commented Nov 19, 2018

/assign @jlewi

@gaocegege
Copy link
Member Author

/approve
/hold cancel

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants