Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an e2etest for running distributed training TFJob #862

Merged
merged 4 commits into from
Nov 2, 2018

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Nov 1, 2018

Fixes #842


This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @gaocegege

@coveralls
Copy link

coveralls commented Nov 1, 2018

Coverage Status

Coverage remained the same at 57.075% when pulling 735810c on richardsliu:dist_e2etest into abb3134 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dc296b4 into kubeflow:master Nov 2, 2018
@richardsliu richardsliu deleted the dist_e2etest branch November 2, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants