Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Update to 1.10 #856

Merged
merged 5 commits into from
Oct 30, 2018
Merged

vendor: Update to 1.10 #856

merged 5 commits into from
Oct 30, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Oct 29, 2018

/assign @johnugeorge

/cc @zjj2wry


This change is Reviewable

Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
@TravisBuddy

This comment has been minimized.

@gaocegege
Copy link
Member Author

/cc @jlewi @richardsliu

Should we follow the convention of the k8s community and keep multiple branches (release-1.9, release-1.10)? Or we just merge it into master directly?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 57.181% when pulling 70fdd04 on gaocegege:1.10 into 9c24967 on kubeflow:master.

@coveralls
Copy link

coveralls commented Oct 29, 2018

Coverage Status

Coverage increased (+0.04%) to 57.075% when pulling df02e5a on gaocegege:1.10 into 9c24967 on kubeflow:master.

@TravisBuddy

This comment has been minimized.

@johnugeorge
Copy link
Member

/lgtm

@jlewi
Copy link
Contributor

jlewi commented Oct 30, 2018

What are we upgrading to 1.10? The K8s client library? Why are we upgrading it? Are there specific features we want that are only in 1.10?

What does this mean in terms of the K8s versions we can work with? Can we still run on older versions of Kubernetes? e.g. 1.9?

@gaocegege
Copy link
Member Author

We can run in 1.9, this PR just upgrades vendor. We expect this upgrade because if your project depends on tf-operator and k8s code, k8s in vendor is 1.10, and tf-operator relies on k8s 1.9, then there is conflicts in vendor. The best way to solve it is to maintain multiple branches like https://github.com/kubernetes/code-generator/tree/release-1.10.

BTW, this is about development and does not affect usage. Users can run the operator in 1.9 or 1.10 or above.

@jlewi
Copy link
Contributor

jlewi commented Oct 30, 2018

Thanks for the explanation.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 513e107 into kubeflow:master Oct 30, 2018
@gaocegege gaocegege deleted the 1.10 branch October 30, 2018 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants