-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: Update to 1.10 #856
Conversation
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Ce Gao <[email protected]>
/cc @jlewi @richardsliu Should we follow the convention of the k8s community and keep multiple branches (release-1.9, release-1.10)? Or we just merge it into master directly? |
Signed-off-by: Ce Gao <[email protected]>
This comment has been minimized.
This comment has been minimized.
/lgtm |
What are we upgrading to 1.10? The K8s client library? Why are we upgrading it? Are there specific features we want that are only in 1.10? What does this mean in terms of the K8s versions we can work with? Can we still run on older versions of Kubernetes? e.g. 1.9? |
We can run in 1.9, this PR just upgrades vendor. We expect this upgrade because if your project depends on tf-operator and k8s code, k8s in vendor is 1.10, and tf-operator relies on k8s 1.9, then there is conflicts in vendor. The best way to solve it is to maintain multiple branches like https://github.com/kubernetes/code-generator/tree/release-1.10. BTW, this is about development and does not affect usage. Users can run the operator in 1.9 or 1.10 or above. |
Thanks for the explanation. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @johnugeorge
/cc @zjj2wry
This change is