Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding corev1 scheme to Events #821

Merged
merged 3 commits into from
Sep 4, 2018
Merged

Adding corev1 scheme to Events #821

merged 3 commits into from
Sep 4, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Sep 4, 2018

One error log appears during the leader election at startup.

Could not construct reference to: '&v1.Endpoints{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"tf-job-operator", GenerateName:"", Namespace:"default", SelfLink:"/api/v1/namespaces/default/endpoints/tf-job-operator", UID:"feb0f9ab-6e64-11e8-bdd9-42010aa00072", ResourceVersion:"18879593", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63664420868, loc:(*time.Location)(0x1b5df80)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string{"control-plane.alpha.kubernetes.io/leader":"{\"holderIdentity\":\"tf-job-operator-5864544fcb-d8c9m\",\"leaseDurationSeconds\":15,\"acquireTime\":\"2018-09-03T12:22:38Z\",\"renewTime\":\"2018-09-03T12:22:38Z\",\"leaderTransitions\":39}"}, OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Subsets:[]v1.EndpointSubset(nil)}' due to: 'no kind is registered for the type v1.Endpoints'. Will not report event: 'Normal' 'LeaderElection' '

This is because endpoints schema was not added during the initialization


This change is Reviewable

@TravisBuddy
Copy link

Travis tests have failed

Hey @johnugeorge,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...
cmd/tf-operator.v2/app/server.go:130::warning: Errors unhandled.,LOW,HIGH (gosec)
cmd/tf-operator.v2/app/server.go:130:16:warning: error return value not checked (v1.AddToScheme(scheme.Scheme)) (errcheck)

3rd Build

gometalinter --config=linter_config.json --vendor ./...
cmd/tf-operator.v2/app/server.go:130::warning: Errors unhandled.,LOW,HIGH (gosec)
cmd/tf-operator.v2/app/server.go:130:16:warning: error return value not checked (v1.AddToScheme(scheme.Scheme)) (errcheck)

travis_time:end:14434c20:start=1536039608633548565,finish=1536039752901322845,duration=144267774280

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 56.932% when pulling 4a6795f on johnugeorge:log into ed91105 on kubeflow:master.

@coveralls
Copy link

coveralls commented Sep 4, 2018

Coverage Status

Coverage increased (+0.07%) to 56.932% when pulling 7a86aae on johnugeorge:log into ed91105 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gaocegege
Copy link
Member

/retest

4 similar comments
@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

/retest

@TravisBuddy
Copy link

Travis tests have failed

Hey @johnugeorge,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...
cmd/tf-operator.v2/app/server.go:131:10:warning: unused variable or constant log.Errorf("CoreV1 Add Scheme failed: %v", err) (no value) used as value (varcheck)
cmd/tf-operator.v2/app/server.go:131:10:warning: error return value not checked (log.Errorf("CoreV1 Add Scheme failed: %v", err) (no value) used as value) (errcheck)
cmd/tf-operator.v2/app/server.go:131:10:warning: log.Errorf("CoreV1 Add Scheme failed: %v", err) (no value) used as value (gosimple, staticcheck, unconvert)

travis_time:end:1b3d3a0b:start=1536041100422767121,finish=1536041169375503655,duration=68952736534

3rd Build

gometalinter --config=linter_config.json --vendor ./...
cmd/tf-operator.v2/app/server.go:131:10:warning: log.Errorf("CoreV1 Add Scheme failed: %v", err) (no value) used as value (gosimple, staticcheck, unconvert)
cmd/tf-operator.v2/app/server.go:131:10:warning: error return value not checked (log.Errorf("CoreV1 Add Scheme failed: %v", err) (no value) used as value) (errcheck)
cmd/tf-operator.v2/app/server.go:131:20:error: logrus.Errorf("CoreV1 Add Scheme failed: %v", err) used as value (vet)
cmd/tf-operator.v2/app/server.go:131:10:warning: unused variable or constant log.Errorf("CoreV1 Add Scheme failed: %v", err) (no value) used as value (varcheck)

travis_time:end:2326ab64:start=1536041063361630069,finish=1536041181583472996,duration=118221842927

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 4, 2018
@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants