Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructing common utility functions #792

Merged
merged 2 commits into from
Aug 26, 2018
Merged

Restructing common utility functions #792

merged 2 commits into from
Aug 26, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Aug 22, 2018

Moving common utility functions to the base


This change is Reviewable

@TravisBuddy
Copy link

Travis tests have failed

Hey @johnugeorge,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...
cmd/tf-operator.v2/app/options/options.go:1::warning: file is not goimported (goimports)

3rd Build

gometalinter --config=linter_config.json --vendor ./...
cmd/tf-operator.v2/app/options/options.go:1::warning: file is not goimported (goimports)

travis_time:end:09e6c629:start=1534970123639600980,finish=1534970272422839557,duration=148783238577

@coveralls
Copy link

coveralls commented Aug 22, 2018

Coverage Status

Coverage increased (+0.1%) to 58.131% when pulling 02b2128 on johnugeorge:minorfix into 3061493 on kubeflow:master.

@johnugeorge
Copy link
Member Author

/retest

3 similar comments
@johnugeorge
Copy link
Member Author

/retest

@gaocegege
Copy link
Member

/retest

@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

@jlewi
I am seeing errors "Exception occured; type <type 'exceptions.TypeError'> message Got an unexpected keyword argument 'async' to method get_namespaced_custom_object"

@johnugeorge
Copy link
Member Author

/retest

@ChanYiLin
Copy link
Member

@johnugeorge the reason is because of the PR #790 update the python Kubernetes lib to 7.0.0
and it changed the parameter async to async_req.
The PR has been merged, we can try the test again.

/lgtm

@ChanYiLin
Copy link
Member

/retest

@johnugeorge
Copy link
Member Author

@ChanYiLin It failed again

@ChanYiLin
Copy link
Member

@johnugeorge I think you can try to rebase the git branch, apply your commit to the master and git push again.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 24, 2018
@ChanYiLin
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member Author

@gaocegege

@johnugeorge
Copy link
Member Author

@jlewi @gaocegege @ScorpioCPH can you approve and merge?

@gaocegege
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

Sorry for the delay.

Thanks for your contribution!

@k8s-ci-robot k8s-ci-robot merged commit 43aaee8 into kubeflow:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants