-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructing common utility functions #792
Conversation
Travis tests have failedHey @johnugeorge, 2nd Buildgometalinter --config=linter_config.json --vendor ./...
3rd Buildgometalinter --config=linter_config.json --vendor ./...
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
@jlewi |
/retest |
@johnugeorge the reason is because of the PR #790 update the python Kubernetes lib to 7.0.0 /lgtm |
/retest |
@ChanYiLin It failed again |
@johnugeorge I think you can try to rebase the git branch, apply your commit to the master and git push again. |
/lgtm |
@jlewi @gaocegege @ScorpioCPH can you approve and merge? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry for the delay. Thanks for your contribution! |
Moving common utility functions to the base
This change is