Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: update openapi_generated.go to support TTLSecondsAfterFinished #769

Merged
merged 1 commit into from
Aug 11, 2018

Conversation

jetmuffin
Copy link
Contributor

@jetmuffin jetmuffin commented Aug 3, 2018

Signed-off-by: JetMuffin [email protected]


This change is Reviewable

@gaocegege
Copy link
Member

/ok-to-test
/lgtm
/approve
Thanks for your contribution!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 58.08% when pulling 6dad567 on JetMuffin:openapi into bb430c9 on kubeflow:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 58.08% when pulling 6dad567 on JetMuffin:openapi into bb430c9 on kubeflow:master.

@gaocegege
Copy link
Member

/retest

1 similar comment
@gaocegege
Copy link
Member

/retest

@jetmuffin
Copy link
Contributor Author

/retest 😂

@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

INFO|2018-08-03T04:10:33|/src/kubeflow/testing/py/kubeflow/testing/util.py|62| level=error msg="handle object: merging object with existing state: unable to recognize \"/tmp/ksonnet-mergepatch290154148\": no matches for kind \"Workflow\" in version \"argoproj.io/v1alpha1\""
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 344, in <module>
    final_result = main()
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 334, in main
    return run(args, file_handler)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 222, in run
    util.run(["ks", "apply", env, "-c", w.component], cwd=w.app_dir)
  File "/src/kubeflow/testing/py/kubeflow/testing/util.py", line 74, in run
    " ".join(command), process.returncode), "\n".join(output))
subprocess.CalledProcessError: Command 'cmd: ks apply kubeflow-tf-operator-presubmit-v1-769-6dad567-916-133a -c workflows exited with code 1' returned non-zero exit status 1

@jlewi Do you have any idea about the issue? I think it is not caused by the PR.

@jetmuffin
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 44c5382 into kubeflow:master Aug 11, 2018
@jetmuffin jetmuffin deleted the openapi branch August 11, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants