-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring TF operator code #767
Conversation
Travis tests have failedHey @johnugeorge, 2nd Buildgometalinter --config=linter_config.json --vendor ./...
3rd Buildgometalinter --config=linter_config.json --vendor ./...
|
/assign @ankushagarwal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
@@ -15,32 +15,31 @@ | |||
package controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to use the logger? Then I think we could put the code in a separate package.
@jlewi @gaocegege Changes are complete now. Can you review it now ? |
/lgtm @jlewi @gaocegege Can you of you approve? I don't have permissions. |
/approve Thanks for your awesome contribution! Hope we should share more implementation in the future. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR tracks the refactoring of TF Operator code for separating common code. The code has been restructured into multiple packages.
This change is