Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring TF operator code #767

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Refactoring TF operator code #767

merged 3 commits into from
Aug 3, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Aug 1, 2018

This PR tracks the refactoring of TF Operator code for separating common code. The code has been restructured into multiple packages.


This change is Reviewable

@TravisBuddy
Copy link

Travis tests have failed

Hey @johnugeorge,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...
pkg/controller.v2/controller_logger.go:1::warning: file is not goimported (goimports)
pkg/controller.v2/jobcontroller.go:1::warning: file is not goimported (goimports)

3rd Build

gometalinter --config=linter_config.json --vendor ./...
pkg/controller.v2/controller_logger.go:1::warning: file is not goimported (goimports)
pkg/controller.v2/jobcontroller.go:1::warning: file is not goimported (goimports)

travis_time:end:1554f8db:start=1533146387495504523,finish=1533146532437841752,duration=144942337229

@coveralls
Copy link

coveralls commented Aug 1, 2018

Coverage Status

Coverage increased (+0.7%) to 58.151% when pulling 25b110c on johnugeorge:refactor into 90259e7 on kubeflow:master.

@jlewi
Copy link
Contributor

jlewi commented Aug 1, 2018

/assign @ankushagarwal

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@@ -15,32 +15,31 @@
package controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to use the logger? Then I think we could put the code in a separate package.

@johnugeorge johnugeorge changed the title WIP: Refactoring TF operator code Refactoring TF operator code Aug 2, 2018
@johnugeorge
Copy link
Member Author

@jlewi @gaocegege Changes are complete now. Can you review it now ?

@ankushagarwal
Copy link

/lgtm

@jlewi @gaocegege Can you of you approve? I don't have permissions.

@gaocegege
Copy link
Member

/approve

@johnugeorge

Thanks for your awesome contribution! Hope we should share more implementation in the future.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants