Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer_guide.md for v1alpha2 #726

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

lovejoy
Copy link
Contributor

@lovejoy lovejoy commented Jul 13, 2018

update to the correct directory


This change is Reviewable

@lovejoy
Copy link
Contributor Author

lovejoy commented Jul 13, 2018

/assign @jlewi

@coveralls
Copy link

coveralls commented Jul 13, 2018

Coverage Status

Coverage remained the same at 57.349% when pulling 0ea44a8 on lovejoy:patch-2 into 3fba4db on kubeflow:master.

@lovejoy
Copy link
Contributor Author

lovejoy commented Jul 13, 2018

/assign @gaocegege

@jlewi
Copy link
Contributor

jlewi commented Jul 13, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lovejoy
Copy link
Contributor Author

lovejoy commented Jul 13, 2018

/ok-to-test ?

@jlewi
Copy link
Contributor

jlewi commented Jul 14, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit 4838996 into kubeflow:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants