Use logrus instead of glog in service_control #695
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
/cc @gaocegege |
pkg/control/service_control.go
Outdated
| @@ -123,7 +125,9 @@ func (r RealServiceControl) DeleteService(namespace, serviceID string, object ru | |||
| if err != nil { | |||
| return fmt.Errorf("object does not have ObjectMeta, %v", err) | |||
| } | |||
| glog.V(2).Infof("Controller %v deleting service %v/%v", accessor.GetName(), namespace, serviceID) | |||
| if log.GetLevel() >= log.ErrorLevel { | |||
There was a problem hiding this comment.
I think we could just use log.Infof without checking the level. Do you think it is necessary?
There was a problem hiding this comment.
no need to check level, fix it right now
|
/ok-to-test |
|
Please use your account to submit the commit and sign Google CLA. |
|
CLAs look good, thanks! |
|
@codeflitting Could you please set |
Signed-off-by: Pengyu Chen <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: Pengyu Chen <[email protected]>
fix #635
This change is