*: Move test util to separate package #666

gaocegege · 2018-06-14T12:13:21Z

Move the util functions about test to a separate package.

Signed-off-by: Ce Gao [email protected]

This change is

Signed-off-by: Ce Gao <[email protected]>

TravisBuddy · 2018-06-14T13:07:34Z

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...

pkg/util/testutil/pod.go:81:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:85:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/service.go:59:21:warning: error return value not checked (serviceIndexer.Add(service)) (errcheck)
pkg/util/testutil/pod.go:30:2:warning: unused variable or constant controllerName (varcheck)
pkg/util/testutil/pod.go:73:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:77:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)

goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"

=== RUN   TestAddAccelertor
--- PASS: TestAddAccelertor (0.00s)
PASS
coverage: 2.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper	0.076s
=== RUN   TestSetDefaults_TFJob
--- PASS: TestSetDefaults_TFJob (0.00s)
PASS
coverage: 1.8% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1	0.047s
=== RUN   TestSetDefaultTFJob
--- PASS: TestSetDefaultTFJob (0.00s)
PASS
coverage: 2.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2	0.062s
=== RUN   TestValidate
--- PASS: TestValidate (0.00s)
PASS
coverage: 2.9% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation	0.052s
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/controller	[no test files]
=== RUN   TestAddPod
--- PASS: TestAddPod (0.31s)
=== RUN   TestClusterSpec
--- PASS: TestClusterSpec (0.00s)
=== RUN   TestRestartPolicy
--- PASS: TestRestartPolicy (0.00s)
=== RUN   TestExitCode
--- PASS: TestExitCode (0.00s)
=== RUN   TestAddService
--- PASS: TestAddService (0.30s)
=== RUN   TestFailed
--- PASS: TestFailed (0.00s)
=== RUN   TestStatus
--- PASS: TestStatus (0.00s)
=== RUN   TestNormalPath
--- PASS: TestNormalPath (0.01s)
=== RUN   TestRun
--- PASS: TestRun (0.50s)
=== RUN   TestAddTFJob
--- PASS: TestAddTFJob (0.30s)
=== RUN   TestCopyLabelsAndAnnotation
--- PASS: TestCopyLabelsAndAnnotation (0.00s)
=== RUN   TestCreatePods
--- PASS: TestCreatePods (0.01s)
=== RUN   TestCreateService
--- PASS: TestCreateService (0.00s)
=== RUN   TestCreateServicesWithControllerRef
--- PASS: TestCreateServicesWithControllerRef (0.00s)
=== RUN   TestClaimServices
--- PASS: TestClaimServices (0.00s)
PASS
coverage: 33.0% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/controller.v2	1.519s
exit status 1: warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/controller
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/controller.v2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/trainer
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/k8sutil
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/signals
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/testutil
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/train
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/unstructured
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/version
# github.com/kubeflow/tf-operator/pkg/generator
import cycle not allowed in test
package github.com/kubeflow/tf-operator/pkg/generator (test)
	imports github.com/kubeflow/tf-operator/pkg/generator

FAIL	github.com/kubeflow/tf-operator/pkg/generator [setup failed]

3rd Build

gometalinter --config=linter_config.json --vendor ./...

pkg/util/testutil/pod.go:30:2:warning: unused variable or constant controllerName (varcheck)
pkg/util/testutil/pod.go:73:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:77:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:81:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:85:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/service.go:59:21:warning: error return value not checked (serviceIndexer.Add(service)) (errcheck)

travis_time:end:10488766:start=1528980786100132690,finish=1528980920615018385,duration=134514885695

goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"

=== RUN   TestAddAccelertor
--- PASS: TestAddAccelertor (0.00s)
PASS
coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper	0.034s	coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestSetDefaults_TFJob
--- PASS: TestSetDefaults_TFJob (0.00s)
PASS
coverage: 6.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1	0.032s	coverage: 6.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestSetDefaultTFJob
--- PASS: TestSetDefaultTFJob (0.00s)
PASS
coverage: 13.7% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2	0.031s	coverage: 13.7% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestValidate
--- PASS: TestValidate (0.00s)
PASS
coverage: 14.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation	0.032s	coverage: 14.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/controller	[no test files]
=== RUN   TestAddPod
time="2018-06-14T12:55:44Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:44Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:44Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:44Z" level=info msg="Started workers"
--- PASS: TestAddPod (0.31s)
=== RUN   TestClusterSpec
--- PASS: TestClusterSpec (0.00s)
=== RUN   TestRestartPolicy
--- PASS: TestRestartPolicy (0.00s)
=== RUN   TestExitCode
time="2018-06-14T12:55:44Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:44Z" level=info msg="Need to restart the pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:44Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:44Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (370.489µs)"
--- PASS: TestExitCode (0.00s)
=== RUN   TestAddService
time="2018-06-14T12:55:44Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:44Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:44Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:44Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:44Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:44Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:44Z" level=info msg="Started workers"
time="2018-06-14T12:55:44Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
--- PASS: TestAddService (0.30s)
=== RUN   TestFailed
--- PASS: TestFailed (0.00s)
=== RUN   TestStatus
--- PASS: TestStatus (0.00s)
=== RUN   TestNormalPath
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (416.429µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (256.835µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (172.654µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-0" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-0" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-1" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-1" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (559.154µs)"
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (328.147µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (698.631µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (717.285µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (348.91µs)"
--- PASS: TestNormalPath (0.01s)
=== RUN   TestRun
time="2018-06-14T12:55:45Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:45Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
--- PASS: TestRun (0.50s)
=== RUN   TestAddTFJob
time="2018-06-14T12:55:45Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:45Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:45Z" level=info msg="TFJob test-tfjob is created."
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
--- PASS: TestAddTFJob (0.30s)
=== RUN   TestCopyLabelsAndAnnotation
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:45Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:45Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (372.414µs)"
--- PASS: TestCopyLabelsAndAnnotation (0.00s)
=== RUN   TestCreatePods
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
--- PASS: TestCreatePods (0.01s)
=== RUN   TestCreateService
--- PASS: TestCreateService (0.00s)
=== RUN   TestCreateServicesWithControllerRef
--- PASS: TestCreateServicesWithControllerRef (0.00s)
=== RUN   TestClaimServices
--- PASS: TestClaimServices (0.00s)
PASS
coverage: 46.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/controller.v2	1.499s	coverage: 46.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
exit status 1: warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/controller
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/controller.v2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/trainer
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/k8sutil
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/signals
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/testutil
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/train
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/unstructured
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/version
# github.com/kubeflow/tf-operator/pkg/generator
import cycle not allowed in test
package github.com/kubeflow/tf-operator/pkg/generator (test)
	imports github.com/kubeflow/tf-operator/pkg/generator

FAIL	github.com/kubeflow/tf-operator/pkg/generator [setup failed]


travis_time:end:00d5f902:start=1528980920620676889,finish=1528980946056338911,duration=25435662022

Signed-off-by: Ce Gao <[email protected]>

coveralls · 2018-06-15T03:19:09Z

Coverage increased (+0.3%) to 57.745% when pulling 224ad6f on gaocegege:refactor into f8fa47e on kubeflow:master.

TravisBuddy · 2018-06-15T03:19:09Z

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

gometalinter --config=linter_config.json --vendor ./...

pkg/util/testutil/service.go:59:21:warning: error return value not checked (serviceIndexer.Add(service)) (errcheck)
pkg/util/testutil/pod.go:30:2:warning: unused variable or constant controllerName (varcheck)
pkg/util/testutil/pod.go:73:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:77:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:81:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:85:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)

travis_time:end:114c09f6:start=1529031899150653153,finish=1529031999953872851,duration=100803219698

Signed-off-by: Ce Gao <[email protected]>

gaocegege · 2018-06-15T04:33:58Z

/assign @jlewi

It is to ease the maintenance.

gaocegege · 2018-06-15T04:41:22Z

I am merging it since it blocks #672

k8s-ci-robot · 2018-06-15T04:41:34Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* *: Refactor Signed-off-by: Ce Gao <[email protected]> * travis: Remove util from coverage test Signed-off-by: Ce Gao <[email protected]> * test: Add copyright holder Signed-off-by: Ce Gao <[email protected]> * *: Fix errors Signed-off-by: Ce Gao <[email protected]> * generator: Fix test Signed-off-by: Ce Gao <[email protected]> * pods: Add error handler Signed-off-by: Ce Gao <[email protected]> * testutil: Fix linting errors Signed-off-by: Ce Gao <[email protected]>

*: Refactor

31977ed

Signed-off-by: Ce Gao <[email protected]>

k8s-ci-robot requested review from jimexist and willb June 14, 2018 12:13

k8s-ci-robot added the size/XL label Jun 14, 2018

gaocegege added 3 commits June 14, 2018 20:14

travis: Remove util from coverage test

34c32cc

Signed-off-by: Ce Gao <[email protected]>

test: Add copyright holder

b70de2a

Signed-off-by: Ce Gao <[email protected]>

*: Fix errors

1a0d9fb

Signed-off-by: Ce Gao <[email protected]>

kubeflow deleted a comment from TravisBuddy Jun 14, 2018

gaocegege added 2 commits June 15, 2018 11:02

generator: Fix test

38afe10

Signed-off-by: Ce Gao <[email protected]>

pods: Add error handler

15453bf

Signed-off-by: Ce Gao <[email protected]>

gaocegege mentioned this pull request Jun 15, 2018

controller: Move control interface to control package #670

Merged

gaocegege added the area/0.3.0 label Jun 15, 2018

testutil: Fix linting errors

224ad6f

Signed-off-by: Ce Gao <[email protected]>

kubeflow deleted a comment from TravisBuddy Jun 15, 2018

gaocegege removed the area/0.3.0 label Jun 15, 2018

k8s-ci-robot assigned jlewi Jun 15, 2018

gaocegege added lgtm approved labels Jun 15, 2018

k8s-ci-robot merged commit 050a717 into kubeflow:master Jun 15, 2018

gaocegege deleted the refactor branch June 15, 2018 04:42

gaocegege mentioned this pull request Jun 15, 2018

[v1alpha2] Move test util to separate package #664

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Move test util to separate package #666

*: Move test util to separate package #666

gaocegege commented Jun 14, 2018 •

edited by jlewi

Loading

TravisBuddy commented Jun 14, 2018

coveralls commented Jun 15, 2018 •

edited

Loading

TravisBuddy commented Jun 15, 2018

gaocegege commented Jun 15, 2018

gaocegege commented Jun 15, 2018

k8s-ci-robot commented Jun 15, 2018

*: Move test util to separate package #666

*: Move test util to separate package #666

Conversation

gaocegege commented Jun 14, 2018 • edited by jlewi Loading

TravisBuddy commented Jun 14, 2018

Travis tests have failed

2nd Build

3rd Build

coveralls commented Jun 15, 2018 • edited Loading

TravisBuddy commented Jun 15, 2018

Travis tests have failed

3rd Build

gaocegege commented Jun 15, 2018

gaocegege commented Jun 15, 2018

k8s-ci-robot commented Jun 15, 2018

gaocegege commented Jun 14, 2018 •

edited by jlewi

Loading

coveralls commented Jun 15, 2018 •

edited

Loading