Updates to enable e2e test for v1alpha2 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/LGTM |
gaocegege
reviewed
Jun 7, 2018
py/test_runner.py
Outdated
| else: | ||
| for replicakey in results.get("spec", {}).get("tfReplicaSpecs", {}): | ||
| logging.info("replicakey: %s", results.get("spec", {}).get("tfReplicaSpecs", {}).get(replicakey, {})) | ||
| num_expected += results.get("spec", {}).get("tfReplicaSpecs", {}).get(replicakey, {}).get("replicas", 0) |
There was a problem hiding this comment.
Could the code work when there is a replicaspec worker while it does not specify the replicas (In this case the replicas will be set to 1)?
ankushagarwal
force-pushed
the
ankushagarwal-v1alpha2-test
branch
from
c25eacf to
579b515
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Fixed lint issues. @gaocegege Can you review again? |
|
/lgtm |
|
/retest |
yph152
pushed a commit
to yph152/tf-operator
that referenced
this pull request
Jun 18, 2018
* Pass tfjob version to wait_for_job * Handle case where replicas is not set * Update
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
* Pass tfjob version to wait_for_job * Handle case where replicas is not set * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @gaocegege
Related kubeflow/kubeflow#852
This change is