TFJob client should not block forever trying to get the namespace object #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect. * TFJob wait should run the request asyncronously so we don't end up blocking forever. Fix kubeflow#606
jlewi
changed the title
|
/assign @gaocegege |
|
/LGTM |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merge it manually since coveralls blocks the auto merge. |
1 similar comment
yph152
pushed a commit
to yph152/tf-operator
that referenced
this pull request
Jun 18, 2018
…ect (kubeflow#607) * TFJob client should not block forever trying to get the namespace object. * TFJob wait should run the request asyncronously so we don't end up blocking forever. Fix kubeflow#606 * Fix lint.
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
…ect (kubeflow#607) * TFJob client should not block forever trying to get the namespace object. * TFJob wait should run the request asyncronously so we don't end up blocking forever. Fix kubeflow#606 * Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forever.
Fix #606
This change is