Fix the gometalinter support

[wgliang]

Fix the gometalinter support

---

This change is 

[wgliang]

/assign @gaocegege

[gaocegege]

Close #586

/ok-to-test
/approve
/lgtm

Thanks for your contribution 🎉

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Coverage remained the same at 49.782% when pulling 5dbf626 on wgliang:master.gofmt into e71d96b on kubeflow:master.

[gaocegege]

Please rebase the master. I merged a PR which fixes our CI several minutes before

#581

@wgliang

[wgliang]

/retest

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[TravisBuddy]

Travis tests have failed

Hey @wgliang,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json ./cmd/...

cmd/tf-operator.v2/app/server.go:106:9:warning: error return value not checked (tc.Run(opt.Threadiness, stopCh)) (errcheck)
cmd/tf-operator/app/server.go:95:17:warning: error return value not checked (controller.Run(1, stopCh)) (errcheck)

gometalinter --config=linter_config.json ./test/e2e/...

test/e2e/main.go:1::warning: file is not goimported (goimports)
test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)

3rd Build

gometalinter --config=linter_config.json ./cmd/...

cmd/tf-operator.v2/app/server.go:106:9:warning: error return value not checked (tc.Run(opt.Threadiness, stopCh)) (errcheck)
cmd/tf-operator/app/server.go:95:17:warning: error return value not checked (controller.Run(1, stopCh)) (errcheck)

travis_time:end:0c6fa740:start=1525948266188802823,finish=1525948400633519876,duration=134444717053

gometalinter --config=linter_config.json ./test/e2e/...

test/e2e/main.go:1::warning: file is not goimported (goimports)
test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)

travis_time:end:1314c80c:start=1525948459682682495,finish=1525948523369418873,duration=63686736378

[gaocegege]

Thanks for your contribution!

It seems that we have some linting issues. And if you do not fix them I can merge the PR manually and fix in another PR.

WDYT?

[gaocegege]

We dicussed privately and decided to merge it ASAP and let me fix the errors in another PR.

[gaocegege]

Thanks for your contribution! 😃