pod: Add update logic #582
Conversation
|
/retest |
1 similar comment
|
/retest |
|
/status blocked By #581 |
Signed-off-by: Ce Gao <[email protected]>
| curControllerRef := metav1.GetControllerOf(curPod) | ||
| oldControllerRef := metav1.GetControllerOf(oldPod) | ||
| controllerRefChanged := !reflect.DeepEqual(curControllerRef, oldControllerRef) | ||
| if controllerRefChanged && oldControllerRef != nil { |
There was a problem hiding this comment.
Is this used for updating v1alpha1 to v1alpha2?
IOW, why does ControllerRef changed?
There was a problem hiding this comment.
We could remove the check here. It should not happen in our case. I just copied it from job controller. WDYT
There was a problem hiding this comment.
The pods maybe modified by other controllers by some mistakes.
So I think keep this check is more better :)
|
/retest |
| curControllerRef := metav1.GetControllerOf(curPod) | ||
| oldControllerRef := metav1.GetControllerOf(oldPod) | ||
| controllerRefChanged := !reflect.DeepEqual(curControllerRef, oldControllerRef) | ||
| if controllerRefChanged && oldControllerRef != nil { |
There was a problem hiding this comment.
The pods maybe modified by other controllers by some mistakes.
So I think keep this check is more better :)
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScorpioCPH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
/assign @ScorpioCPH
Signed-off-by: Ce Gao [email protected]
This change is