Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pylinrc: Add dist_mnist #581

Merged
merged 1 commit into from
May 10, 2018
Merged

.pylinrc: Add dist_mnist #581

merged 1 commit into from
May 10, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 10, 2018

Fix test failures in #549

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@gaocegege
Copy link
Member Author

/priority p0
/assign @ScorpioCPH

@coveralls
Copy link

coveralls commented May 10, 2018

Coverage Status

Coverage decreased (-0.08%) to 49.782% when pulling 9ed6dfd on gaocegege:ignore into e380580 on kubeflow:master.

@gaocegege
Copy link
Member Author

I run the mnist test in upstream/master and got:

Traceback (most recent call last):
  File "/var/tf_dist_mnist/dist_mnist.py", line 303, in <module>
    tf.app.run()
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 124, in run
    _sys.exit(main(argv))
TypeError: main() takes no arguments (1 given)

Is there anything wrong?

@gaocegege
Copy link
Member Author

I am going to merge it since it blocks a new contributor's PR, which will hurt the passion.

/lgtm
/approve

@k8s-ci-robot
Copy link

@gaocegege: you cannot LGTM your own PR.

In response to this:

I am going to merge it since it blocks a new contributor's PR, which will hurt the passion.

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege added the lgtm label May 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit e71d96b into kubeflow:master May 10, 2018
@gaocegege gaocegege deleted the ignore branch May 10, 2018 09:32
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants