Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace glide with dep in the developer guide #572

Merged
merged 1 commit into from
May 8, 2018
Merged

replace glide with dep in the developer guide #572

merged 1 commit into from
May 8, 2018

Conversation

ChanYiLin
Copy link
Member

@ChanYiLin ChanYiLin commented May 7, 2018

Since we have changed from glide to dep, we should update the developer guide.
Thanks!


This change is Reviewable

@ChanYiLin
Copy link
Member Author

/assign @gaocegege
Could you please help me to have a look
thanks.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented May 7, 2018

Coverage Status

Coverage increased (+0.08%) to 49.861% when pulling bb6005b on ChanYiLin:master into e69e88d on kubeflow:master.

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/retest

1 similar comment
@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 556e2fc into kubeflow:master May 8, 2018
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants