Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: Remove #566

Merged
merged 3 commits into from
May 5, 2018
Merged

chart: Remove #566

merged 3 commits into from
May 5, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 2, 2018

@coveralls
Copy link

coveralls commented May 2, 2018

Coverage Status

Coverage decreased (-0.08%) to 49.4% when pulling 7de9d3f on gaocegege:chart into 19d611c on kubeflow:master.

Signed-off-by: Ce Gao <[email protected]>
@ScorpioCPH
Copy link
Member

/lgtm

@gaocegege
Copy link
Member Author

/retest
/approve

@gaocegege
Copy link
Member Author

/retest

@ankushagarwal
Copy link

@gaocegege Can you resolve lint issues?

% pylint --rcfile=.pylintrc py/release.py                                                                                                                                (1)
Using config file /Users/agwl/git/kf/tf-operator/.pylintrc
************* Module py.release
W:237,29: Unused argument 'publish_path' (unused-argument)
W: 12, 0: Unused import glob (unused-import)

-----------------------------------
Your code has been rated at 9.93/10
% pylint --rcfile=.pylintrc py/release_test.py                                                                                                                           (4)
Using config file /Users/agwl/git/kf/tf-operator/.pylintrc
************* Module py.release_test
W:  5, 0: Unused import yaml (unused-import)

-----------------------------------
Your code has been rated at 9.68/10

@gaocegege
Copy link
Member Author

Yeah, I will do it

Signed-off-by: Ce Gao <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm label May 5, 2018
Signed-off-by: Ce Gao <[email protected]>
@gaocegege
Copy link
Member Author

/retest

1 similar comment
@gaocegege
Copy link
Member Author

/retest

@ankushagarwal
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2a22ad4 into kubeflow:master May 5, 2018
@gaocegege gaocegege deleted the chart branch May 28, 2018 05:56
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
* chart: Remove

Signed-off-by: Ce Gao <[email protected]>

* py: Fix lint issues

Signed-off-by: Ce Gao <[email protected]>

* release_test: Revert

Signed-off-by: Ce Gao <[email protected]>
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
* chart: Remove

Signed-off-by: Ce Gao <[email protected]>

* py: Fix lint issues

Signed-off-by: Ce Gao <[email protected]>

* release_test: Revert

Signed-off-by: Ce Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants