Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Ignore generated code #453

Merged
merged 2 commits into from
Mar 13, 2018
Merged

travis: Ignore generated code #453

merged 2 commits into from
Mar 13, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Mar 11, 2018

Now our coverage test includes generated code and this PR is to remove them from the list of coveralls.

Coverage increased (+16.3%) to 44.86% when pulling e97e51a on gaocegege:test-ignore into 423b0d0 on kubeflow:master.

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@coveralls
Copy link

coveralls commented Mar 11, 2018

Coverage Status

Coverage increased (+16.3%) to 44.86% when pulling e97e51a on gaocegege:test-ignore into 423b0d0 on kubeflow:master.

@gaocegege
Copy link
Member Author

/assign @ScorpioCPH

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any goveralls flag to ignore directories recursively?

@gaocegege
Copy link
Member Author

gaocegege commented Mar 12, 2018

@ScorpioCPH I tried to find it, but I think there is no way. goveralls uses filepath.Match, and it requires full match.

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ScorpioCPH
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScorpioCPH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c62769 into kubeflow:master Mar 13, 2018
@gaocegege gaocegege deleted the test-ignore branch March 26, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants