Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS file for dashboard #446

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Add OWNERS file for dashboard #446

merged 2 commits into from
Mar 8, 2018

Conversation

wbuchwalter
Copy link
Contributor

@wbuchwalter wbuchwalter commented Mar 8, 2018

fix #443.


This change is Reviewable

@coveralls
Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage decreased (-0.1%) to 28.486% when pulling 5ce1551 on wbuchwalter:dash-owners into d3a615d on kubeflow:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.606% when pulling fc37492 on wbuchwalter:dash-owners into d3a615d on kubeflow:master.

dashboard/OWNERS Outdated
@@ -0,0 +1,14 @@
approvers:
- jlewi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove me. I'm already a root approver and I don't have special knowledge of the Dashboard.

Also do you want to be listed as a root approver
https://github.com/kubeflow/tf-operator/blob/master/OWNERS#L13

I know you have a different role but it might make more sense to have you focus reviewing the UI
and then also kubeflow/examples

dashboard/OWNERS Outdated
- jlewi
- wbuchwalter
- Jimexist
reviewers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all of these reviewers.
Approvers shouldn't also be listed as reviewers.

None of the non-approvers listed here have special familiarity with react/javascript.
I sent a request yesterday for more people with javascript/react experience to volunteer but we'll see.

You could add @swiftdiaries as a reviewer. He's working on the central UI.

@wbuchwalter
Copy link
Contributor Author

wbuchwalter commented Mar 8, 2018

@jlewi per your comment:

  • Added myself as a root approver.
  • Added only @jimexist as an approver in the dashboard dir (since he is not root approver)
  • Added @swiftdiaries as a reviewer in the dashboard dir
  • Cleaned the root OWNERS file by removing the reviewers that were already approvers

@jlewi
Copy link
Contributor

jlewi commented Mar 8, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 83c1ab2 into kubeflow:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a suitable OWNERS file in /dashboard
4 participants