-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OWNERS file for dashboard #446
Conversation
dashboard/OWNERS
Outdated
@@ -0,0 +1,14 @@ | |||
approvers: | |||
- jlewi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove me. I'm already a root approver and I don't have special knowledge of the Dashboard.
Also do you want to be listed as a root approver
https://github.com/kubeflow/tf-operator/blob/master/OWNERS#L13
I know you have a different role but it might make more sense to have you focus reviewing the UI
and then also kubeflow/examples
dashboard/OWNERS
Outdated
- jlewi | ||
- wbuchwalter | ||
- Jimexist | ||
reviewers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all of these reviewers.
Approvers shouldn't also be listed as reviewers.
None of the non-approvers listed here have special familiarity with react/javascript.
I sent a request yesterday for more people with javascript/react experience to volunteer but we'll see.
You could add @swiftdiaries as a reviewer. He's working on the central UI.
@jlewi per your comment:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix #443.
This change is