add go 1.10 support in travis #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
Pull Request Test Coverage Report for Build 881
💛 - Coveralls |
jlewi
reviewed
Feb 23, 2018
.travis.yml
Outdated
| @@ -9,6 +9,7 @@ go: | |||
| # TODO jiayu: re-evaluate the pending issues and add back `gotype` | |||
| - 1.8 | |||
| - 1.9 | |||
| - "1.10" | |||
There was a problem hiding this comment.
Why the quotes here abut not above?
There was a problem hiding this comment.
jimexist
commented
Feb 24, 2018
| - 1.9 | ||
| - "1.8" | ||
| - "1.9" | ||
| - "1.10" | ||
|
|
There was a problem hiding this comment.
@jlewi travis-ci/travis-ci#9247
fixed for all above
|
@jimexist: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jlewi
approved these changes
Feb 24, 2018
|
The presubmit test failed because of #404 which is unrelated to this PR. So merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding go 1.10 support
This change is