Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the dup comment tag #1274

Merged
merged 2 commits into from
May 25, 2021
Merged

fix: Remove the dup comment tag #1274

merged 2 commits into from
May 25, 2021

Conversation

gaocegege
Copy link
Member

/assign @ChanYiLin @terrytangyuan

Signed-off-by: cegao [email protected]

@coveralls
Copy link

coveralls commented May 10, 2021

Coverage Status

Coverage remained the same at 71.429% when pulling 19f28ab on gaocegege:typo into 9a29787 on kubeflow:master.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/retest

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@aws-kf-ci-bot
Copy link
Contributor

@gaocegege: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 19f28ab link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaocegege
Copy link
Member Author

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/mnt/test-data-volume/kubeflow-tf-operator-presubmit-v1-1274-19f28ab-1616-7f01/src/kubeflow/tf-operator/py/kub
eflow/tf_operator/simple_tfjob_tests.py", line 5, in <module>
    from kubeflow.tf_operator import test_runner, tf_job_client
  File "/mnt/test-data-volume/kubeflow-tf-operator-presubmit-v1-1274-19f28ab-1616-7f01/src/kubeflow/tf-operator/py/kub
eflow/tf_operator/test_runner.py", line 12, in <module>
    from google.cloud import storage  # pylint: disable=no-name-in-module
ModuleNotFoundError: No module named 'google.cloud'

@ChanYiLin
Copy link
Member

I will take a look at the testing issue

@gaocegege
Copy link
Member Author

@ChanYiLin Thanks!

@gaocegege gaocegege merged commit faf3486 into kubeflow:master May 25, 2021
@gaocegege gaocegege deleted the typo branch May 25, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants