Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote Kustomize build option in standalone installation instructions #1266

Merged
merged 1 commit into from
May 25, 2021

Conversation

verult
Copy link
Contributor

@verult verult commented Apr 2, 2021

This doesn't require cloning the repo, making one-line installation possible.

@aws-kf-ci-bot
Copy link
Contributor

Hi @verult. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@verult
Copy link
Contributor Author

verult commented Apr 2, 2021

/assign @yanniszark @gaocegege

@coveralls
Copy link

coveralls commented Apr 2, 2021

Coverage Status

Coverage remained the same at 71.429% when pulling 5a255e6 on verult:patch-1 into 58c9bc4 on kubeflow:master.

@@ -20,7 +20,7 @@ run distributed or non-distributed TensorFlow jobs on Kubernetes.
## Installation

```bash
kustomize build manifests/overlays/standalone | kubectl apply -f -
kustomize build "github.com/kubeflow/tf-operator.git/manifests/overlays/standalone?ref=v1.1.0" | kubectl apply -f -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pointing master branch instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master branch could contain unstable changes. It would be safer to point to a stable version, but it does take a bit more work during the release process to have to update this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can include instructions for installing both dev version and stable version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, updated

…ions

This doesn't require cloning the repo, making one-line installation possible.
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: terrytangyuan, verult
To complete the pull request process, please ask for approval from gaocegege after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@verult
Copy link
Contributor Author

verult commented Apr 24, 2021

/test kubeflow-tf-operator-presubmit

@aws-kf-ci-bot
Copy link
Contributor

@verult: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test kubeflow-tf-operator-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaocegege
Copy link
Member

/ok-to-test

@aws-kf-ci-bot
Copy link
Contributor

@verult: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 5a255e6 link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@verult
Copy link
Contributor Author

verult commented Apr 26, 2021

Is the presubmit failure a known issue? A README change probably wouldn't trigger a failure right?

@gaocegege
Copy link
Member

@verult Yeah, it is a separate issue #1277

I am merging it manually.

@gaocegege gaocegege merged commit 13b17b0 into kubeflow:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants