Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change the message for running condition #1230

Merged
merged 1 commit into from
Jan 31, 2021
Merged

feat: Change the message for running condition #1230

merged 1 commit into from
Jan 31, 2021

Conversation

gaocegege
Copy link
Member

Signed-off-by: cegao [email protected]

@gaocegege
Copy link
Member Author

/assign @terrytangyuan

@gaocegege
Copy link
Member Author

/assign @ChanYiLin

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.59% when pulling 9548b51 on gaocegege:run into 9741c0c on kubeflow:master.

terrytangyuan
terrytangyuan approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

andreyvelich
andreyvelich approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/retest

@aws-kf-ci-bot
Copy link
Contributor

@gaocegege: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 9548b51 link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaocegege gaocegege merged commit 8ec1acb into kubeflow:master Jan 31, 2021
@gaocegege gaocegege deleted the run branch January 31, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@terrytangyuan terrytangyuan

@ChanYiLin ChanYiLin

@andreyvelich andreyvelich

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gaocegege @coveralls @k8s-ci-robot @andreyvelich @aws-kf-ci-bot @terrytangyuan @ChanYiLin