Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion time setting bug #1226

Merged

Conversation

shaowei-su
Copy link
Contributor

Follow up to issue: #1223, where failed job completion timestamp was not properly configured before.

@aws-kf-ci-bot
Copy link
Contributor

Hi @shaowei-su. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @ChanYiLin

@gaocegege
Copy link
Member

/ok-to-test

@ChanYiLin
Copy link
Member

/lgtm
/approve
Thanks for your contribution 👍

@gaocegege
Copy link
Member

Fix #1223

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.59% when pulling 4c07585 on shaowei-su:shaowei--fix-job-status-update into 169453e on kubeflow:master.

@aws-kf-ci-bot
Copy link
Contributor

@shaowei-su: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 4c07585 link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaocegege
Copy link
Member

@ChanYiLin Can you please help us with the CI problem?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChanYiLin, shaowei-su, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChanYiLin
Copy link
Member

@ChanYiLin Can you please help us with the CI problem?

Yes, I am working on it now, I will try to finish it in this two days.

@gaocegege
Copy link
Member

Thanks, I am merging this PR manually.

@gaocegege gaocegege merged commit 5e69262 into kubeflow:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants