-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkCRDExists func return true when k8s cluster is not connected #1207
Conversation
when k8s cluster is not connected (may be any network issue), log message like this {"filename":"app/server.go:219","level":"error","msg":"Get "https://10.107.104.120:6443/apis/kubeflow.org/v1/tfjobs\": dial tcp 10.107.104.120:6443: i/o timeout","time":"2020-12-30T16:35:14+08:00"} checkCRDExists will return true , that is not the right way
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@gaocegege Do you have a minute to take a look ? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for your contribution! 🎉 👍
Please sign the CLA, thanks. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, oikomi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1206
when k8s cluster is not connected (may be any network issue), log message like this
{"filename":"app/server.go:219","level":"error","msg":"Get "https://10.107.104.120:6443/apis/kubeflow.org/v1/tfjobs\": dial tcp 10.107.104.120:6443: i/o timeout","time":"2020-12-30T16:35:14+08:00"}
checkCRDExists will return true , that is not the right way