Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkCRDExists func return true when k8s cluster is not connected #1207

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Conversation

oikomi
Copy link
Contributor

@oikomi oikomi commented Dec 30, 2020

when k8s cluster is not connected (may be any network issue), log message like this

{"filename":"app/server.go:219","level":"error","msg":"Get "https://10.107.104.120:6443/apis/kubeflow.org/v1/tfjobs\": dial tcp 10.107.104.120:6443: i/o timeout","time":"2020-12-30T16:35:14+08:00"}

checkCRDExists will return true , that is not the right way

when k8s cluster is not connected (may be any network issue), log message like this

{"filename":"app/server.go:219","level":"error","msg":"Get "https://10.107.104.120:6443/apis/kubeflow.org/v1/tfjobs\": dial tcp 10.107.104.120:6443: i/o timeout","time":"2020-12-30T16:35:14+08:00"}

checkCRDExists will return true , that is not the right way
@google-cla
Copy link

google-cla bot commented Dec 30, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.839% when pulling a0f5f97 on oikomi:master into fb7b161 on kubeflow:master.

@oikomi
Copy link
Contributor Author

oikomi commented Dec 30, 2020

@gaocegege Do you have a minute to take a look ? thanks

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

Please sign the CLA, thanks.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, oikomi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oikomi
Copy link
Contributor Author

oikomi commented Dec 30, 2020

@googlebot I signed it!

@k8s-ci-robot k8s-ci-robot merged commit 9dae718 into kubeflow:master Dec 30, 2020
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #1206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants