-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when conditions
is empty.
#1185
Conversation
Hi @Corea. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @jinchihe
I also fixed the same errors on other files. @gaocegege |
@Corea Thanks. Would you please append the error when the conditions is empty? I think for now, the code will return |
/ok-to-test |
@Corea: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Corea The CI problem already fixed, would you please rebase? |
TF Job doesn't have any information about status or condition sometimes, especially just after TF Job started, so the code should return
Okay, I'll do it at the end! |
Hi, any update here? |
Could you answer my question? @jinchihe |
@Corea I'm OK. /lgtm |
/approve Thanks for your contribution! 🎉 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Corea, gaocegege, jinchihe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.