-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple_tfjob_tests py3 version #1134
simple_tfjob_tests py3 version #1134
Conversation
@gabrielwen can we avoid creating more test code that uses test_util.TestCase and instead use pytest if we are creating new tests? Instead of creating a new file
|
4ff7be1
to
bfa9da1
Compare
ok, I'm getting rid of python2 version. will have another follow up PR to remove tf_job_client.py. |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding python3 test version.
This change is