Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple_tfjob_tests py3 version #1134

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

gabrielwen
Copy link
Contributor

@gabrielwen gabrielwen commented Feb 18, 2020

Adding python3 test version.


This change is Reviewable

@coveralls
Copy link

coveralls commented Feb 18, 2020

Coverage Status

Coverage remained the same at 96.512% when pulling 95788fd on gabrielwen:simple_tfjob_tests_py3 into 00ea3ec on kubeflow:master.

@jlewi
Copy link
Contributor

jlewi commented Feb 18, 2020

@gabrielwen can we avoid creating more test code that uses test_util.TestCase and instead use pytest if we are creating new tests?

Instead of creating a new file simple_tfjob_tests_py3 can we either

  • Get rid of the python 2 version or
  • Use the six module to create a single version of the test which is py2 and py3 compatible?

@gabrielwen
Copy link
Contributor Author

@gabrielwen can we avoid creating more test code that uses test_util.TestCase and instead use pytest if we are creating new tests?

Instead of creating a new file simple_tfjob_tests_py3 can we either

  • Get rid of the python 2 version or
  • Use the six module to create a single version of the test which is py2 and py3 compatible?

@jlewi

ok, I'm getting rid of python2 version. will have another follow up PR to remove tf_job_client.py.

@jlewi
Copy link
Contributor

jlewi commented Feb 18, 2020

/lgtm
/approve

@jlewi
Copy link
Contributor

jlewi commented Feb 19, 2020

/lgtm
/approve

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d455e6e into kubeflow:master Feb 19, 2020
@gabrielwen gabrielwen deleted the simple_tfjob_tests_py3 branch February 19, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants