Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add third party licenses #1127

Merged
merged 5 commits into from
Jan 8, 2020
Merged

Add third party licenses #1127

merged 5 commits into from
Jan 8, 2020

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Jan 8, 2020 •
edited by jlewi
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Jan 8, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.512% when pulling ac13c3a on richardsliu:license into 2228b72 on kubeflow:master.

@TravisBuddy
Copy link

Hey @richardsliu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3e4337f0-31ac-11ea-9a36-cd226553ad55

@zhenghuiwang
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 8, 2020
@TravisBuddy
Copy link

Hey @richardsliu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 463d7ad0-31b4-11ea-9a36-cd226553ad55

@TravisBuddy
Copy link

Hey @richardsliu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d00ac5f0-31b5-11ea-9a36-cd226553ad55

gaocegege
gaocegege reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 8, 2020
@TravisBuddy
Copy link

Hey @richardsliu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 06df6a70-31b8-11ea-9a36-cd226553ad55

@TravisBuddy
Copy link

Hey @richardsliu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7f6d3410-31bb-11ea-9a36-cd226553ad55

gaocegege
gaocegege reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5db331d into kubeflow:master Jan 8, 2020
@johnugeorge johnugeorge mentioned this pull request Jan 9, 2020
Closed
@richardsliu richardsliu deleted the license branch December 23, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@jimexist jimexist Awaiting requested review from jimexist

Assignees

@gaocegege gaocegege

@zhenghuiwang zhenghuiwang

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardsliu @coveralls @TravisBuddy @zhenghuiwang @k8s-ci-robot @gaocegege