-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watch function for TFJob python Client API #1122
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Hey @jinchihe, TravisBuddy Request Identifier: 30c28950-2bb2-11ea-9b13-1f3f6380198b |
Travis tests have failedHey @jinchihe, 1st Buildhack/verify-codegen.sh
goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/*.go,pkg/util/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"
TravisBuddy Request Identifier: 92e94830-2d10-11ea-b5b0-b361e22ae1a5 |
Hey @jinchihe, TravisBuddy Request Identifier: ac563a70-2d2a-11ea-b5b0-b361e22ae1a5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks a lot! @gaocegege |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Hey @jinchihe, TravisBuddy Request Identifier: 609e38c0-2d35-11ea-b5b0-b361e22ae1a5 |
Hey @jinchihe, TravisBuddy Request Identifier: 20adeff0-2d38-11ea-b5b0-b361e22ae1a5 |
Hey @jinchihe, TravisBuddy Request Identifier: 29bd3400-2d3a-11ea-b5b0-b361e22ae1a5 |
Hey @jinchihe, TravisBuddy Request Identifier: aec20520-2d3c-11ea-a185-6fb6d15019ed |
/lgtm |
From feedback, user would like to watch the TFJob with key info, such as status, like
kubeflow get tfjob
.The PR is going to add watch function (added one more option
watch=Flase
) for TFJob python Clientget()
andwaiting_for_job()
API, as below:The CI test of
/hack/verify-codegen.sh
failed due to time changed, the PR also update that.This change is