Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the dockerfile for ppc64le #1083

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Conversation

alongzhi
Copy link
Contributor

@alongzhi alongzhi commented Sep 12, 2019

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @alongzhi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

Do you have plan to update the readme in the example?

@gaocegege
Copy link
Member

/ok-to-test

@coveralls
Copy link

coveralls commented Sep 12, 2019

Coverage Status

Coverage remained the same at 96.512% when pulling a7c80c6 on alongzhi:master into b96dcd7 on kubeflow:master.

@alongzhi
Copy link
Contributor Author

Thanks for your contribution! 🎉 👍

Do you have plan to update the readme in the example?

@gaocegege Okay, I will update the readme for this as well. Thanks for your reviewing.

@alongzhi
Copy link
Contributor Author

@gaocegege Hi, do you want me to continue updating readme in this PR, or open a new one?

@gaocegege
Copy link
Member

@alongzhi Both LGTM, it's up to you

@alongzhi
Copy link
Contributor Author

@gaocegege Okay, thanks. I will update it into a new one soon.

@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f6f422 into kubeflow:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants