Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pod): Support custom gang scheduler via CLI argument #1050

Merged
merged 2 commits into from
Aug 29, 2019
Merged

feat(pod): Support custom gang scheduler via CLI argument #1050

merged 2 commits into from
Aug 29, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jul 31, 2019 •
edited by jlewi
Loading

/assign @johnugeorge

/cc @k82cn

Signed-off-by: Ce Gao [email protected]

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested a review from k82cn July 31, 2019 08:08
@coveralls
Copy link

coveralls commented Jul 31, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 76.744% when pulling f1cf13e on gaocegege:gang into d164c36 on kubeflow:master.

@gaocegege
Copy link
Member Author

/test kubeflow-tf-operator-presubmit

1 similar comment
@gaocegege
Copy link
Member Author

/test kubeflow-tf-operator-presubmit

@gaocegege gaocegege changed the title feat(pod): Add annotation for volcano WIP: feat(pod): Add annotation for volcano Aug 19, 2019
@gaocegege gaocegege changed the title WIP: feat(pod): Add annotation for volcano feat(pod): Add annotation for volcano Aug 19, 2019
@gaocegege
Copy link
Member Author

/assign @johnugeorge

@gaocegege gaocegege changed the title feat(pod): Add annotation for volcano feat(pod): Support custom gang scheduler via CLI argument Aug 19, 2019
@k82cn
Copy link
Collaborator

k82cn commented Aug 20, 2019

LGTM, thanks :)

@johnugeorge
Copy link
Member

In case of volcano, who takes care of creating/deleting PodDisruptionBudgets?

@gaocegege
Copy link
Member Author

Volcano does not use PodDisruptionBudget, too. It use PodGroup now. And we should take care of creation and deletion

@johnugeorge
Copy link
Member

And we should take care of creation and deletion

Is this part yet to be added?

@gaocegege
Copy link
Member Author

We have the logic in jobcontroller: https://github.com/kubeflow/tf-operator/blob/master/pkg/common/jobcontroller/jobcontroller.go#L282 and https://github.com/kubeflow/tf-operator/blob/master/pkg/common/jobcontroller/jobcontroller.go#L223

@johnugeorge
Copy link
Member

Got it.
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d2ccd32 into kubeflow:master Aug 29, 2019
@johnugeorge johnugeorge mentioned this pull request Sep 2, 2019
Merged
@gaocegege gaocegege deleted the gang branch December 22, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnugeorge johnugeorge johnugeorge left review comments

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@johnugeorge johnugeorge

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaocegege @coveralls @k82cn @johnugeorge @k8s-ci-robot