Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fix link for simple_TFJob_test #1038

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jul 1, 2019

/hold

After the release, we can fix the link.

Or do you think if we could accept this PR before the release?

@richardsliu

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling aaaae4b on gaocegege:fix into d746bde on kubeflow:master.

@johnugeorge
Copy link
Member

This looks ok to me

/lgtm

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScorpioCPH
Copy link
Member

/approve

Copy link
Member Author

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, ScorpioCPH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ScorpioCPH,gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21b0f38 into kubeflow:master Jul 16, 2019
@gaocegege gaocegege deleted the fix branch December 22, 2020 03:34
ChenYi015 pushed a commit to ChenYi015/training-operator that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants