refactor: add GenPodGroupName method to extract podGroupName in diffe…

[zlcnju]

…rent place

---

This change is 

[k8s-ci-robot]

Hi @zlcnju. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Coverage remained the same at 76.744% when pulling cb95e16 on zlcnju:master into d746bde on kubeflow:master.

[coveralls]

Coverage remained the same at 76.744% when pulling 1787904 on zlcnju:master into d746bde on kubeflow:master.

[zlcnju]

/assign @johnugeorge

[johnugeorge]

@zlcnju Why is this needed now?

[zlcnju]

@zlcnju Why is this needed now?

in kube-batch, the podgroup work when the annotation podgroupname is set。 So, the two places will be equal always. Now, they are equal by the principle both equals tfjob name. This is implicit, extracting one method will make it clear that how the annotation used in podgroup.

[johnugeorge]

/ok-to-test

[gaocegege]

/hold

We are releasing 0.6. Thus we will merge it after the release if the PR is ready.

/lgtm

[gaocegege]

/hold cancel
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment