-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set annotation automatically when EnableGangScheduling is set to true #1032
Conversation
/assign @gaocegege @richardsliu |
1 similar comment
Currently, we don't have tests for gang scheduling feature. How are these annotations used when feature is enabled? Is it a must fix? |
/cc @k82cn |
I think it's necessary.
Should I open a issue for adding the tests for gang-scheduling? |
Yes. This means that this feature is broken now ? Can you add tests ? |
Great, we need this, for now when we enable gang scheduling, we need set the annotation manually and it is not friendly to users. |
/lgtm |
@wackxu Thanks for the update. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To allow the gang-scheduling with using kube-batch, we need to create podGroup and set the annotation
scheduling.k8s.io/group-name: $PODGROUP_NAME
to each pod.When EnableGangScheduling is set to true tf-operator create the podGroup automatically but doesn't set the annotation.
This PR fixes the problem by setting the annotation when create the pods.
fix #1031
This change is