Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix set startTime logic #1001

Merged
merged 1 commit into from
May 27, 2019
Merged

fix set startTime logic #1001

merged 1 commit into from
May 27, 2019

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented May 15, 2019 •
edited
Loading

fix #1000

/assign @gaocegege @jlewi @richardsliu

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from ChanYiLin and cheyang May 15, 2019 08:03
gaocegege
gaocegege reviewed May 15, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

It is a historical problem. And I think we should follow k8s convention now.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/hold

WDYT @richardsliu

@coveralls
Copy link

coveralls commented May 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 76.744% when pulling c1c4cf3 on wackxu:fixstart into 671cdab on kubeflow:master.

@wackxu
Copy link
Contributor Author

wackxu commented May 15, 2019

/retest

@wackxu
Copy link
Contributor Author

wackxu commented May 15, 2019

/test kubeflow-tf-operator-presubmit

2 similar comments
@wackxu
Copy link
Contributor Author

wackxu commented May 15, 2019

/test kubeflow-tf-operator-presubmit

@wackxu
Copy link
Contributor Author

wackxu commented May 16, 2019

/test kubeflow-tf-operator-presubmit

@wackxu
Copy link
Contributor Author

wackxu commented May 16, 2019

@richardsliu Could you have a look at this?

@gaocegege
Copy link
Member

I think it is caused by the CI infra, not your PR. We could retest to try

@johnugeorge
Copy link
Member

Is k8s following the same convention?

@johnugeorge
Copy link
Member

/retest

@wackxu
Copy link
Contributor Author

wackxu commented May 16, 2019 •
edited
Loading

@johnugeorge Yes, for k8s job controller, the startTime is set if startTime is nil no matter how many pods is running.

@gaocegege
Copy link
Member

/retest

Yeah thus I think we need this PR. Thanks

@johnugeorge
Copy link
Member

/retest

1 similar comment
@johnugeorge
Copy link
Member

/retest

@wackxu
Copy link
Contributor Author

wackxu commented May 20, 2019

/hold cancel

@wackxu wackxu closed this May 20, 2019
@wackxu wackxu reopened this May 20, 2019
@gaocegege
Copy link
Member

@wackxu Please rebase

gaocegege
gaocegege reviewed May 27, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wackxu
Copy link
Contributor Author

wackxu commented May 27, 2019

@gaocegege Sorry for the delay, rebased

@gaocegege
Copy link
Member

never mind

Thanks for your contribution!

@wackxu
Copy link
Contributor Author

wackxu commented May 27, 2019

/test kubeflow-tf-operator-presubmit

1 similar comment
@wackxu
Copy link
Contributor Author

wackxu commented May 27, 2019

/test kubeflow-tf-operator-presubmit

@k8s-ci-robot k8s-ci-robot merged commit e031485 into kubeflow:master May 27, 2019
@johnugeorge johnugeorge mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@cheyang cheyang Awaiting requested review from cheyang

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tfjob startTime should set immediately after create instead of wait pod of one replicaType are all running
5 participants
@wackxu @k8s-ci-robot @gaocegege @coveralls @johnugeorge