Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of TensorBoard replica #347

Closed
jlewi opened this issue Jan 25, 2018 · 0 comments
Closed

Get rid of TensorBoard replica #347

jlewi opened this issue Jan 25, 2018 · 0 comments
Assignees
@gaocegege
Labels
area/front-end kind/feature
Milestone
Kubecon Europe

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 25, 2018

I think we should consider getting rid of TensorBoard replica in TFJob.

This was a bit of a hack to simplify TB management by tying the lifetime of TensorBoard to the lifetime of the TFJob.

I think there are better solutions though

I think its easy to forget to set logDir so people will often want to launch TB separately anyway.
@jlewi jlewi added this to the Kubecon Europe milestone Jan 25, 2018
@jlewi jlewi mentioned this issue Jan 25, 2018
Closed
@gaocegege gaocegege mentioned this issue Feb 14, 2018
Merged
@gaocegege gaocegege self-assigned this Feb 16, 2018
@gaocegege gaocegege mentioned this issue Feb 16, 2018
Closed
@mitake mitake mentioned this issue Feb 23, 2018
Closed
jlewi pushed a commit that referenced this issue Feb 27, 2018
@gaocegege @jlewi
Remove TensorBoard related code in operator (#391)
0759f7a 
Ref #347

Blocked until CI is running again.

PS: Dashboard code is not changed.

Signed-off-by: Ce Gao [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaocegege gaocegege

Labels
area/front-end kind/feature
Projects
None yet
Milestone
Kubecon Europe
Development

No branches or pull requests
2 participants
@jlewi @gaocegege