Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tf-operator tests in v1.2-branch #964

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Enable tf-operator tests in v1.2-branch #964

merged 1 commit into from
Aug 17, 2021

Conversation

DeliangFan
Copy link
Contributor

@DeliangFan DeliangFan commented Aug 17, 2021 •
edited by PatrickXYS
Loading

related-issue: #1355

Which issue is resolved by this Pull Request:
Resolves #1355

Description of your changes:

Enable tf-operator tests for v1.2-branch

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

@google-cla google-cla bot added the cla: yes label Aug 17, 2021
@DeliangFan DeliangFan changed the title Enable tf-operator tests in v1.2-branch Enable tf-operator tests in v1.2-branch #1355 Aug 17, 2021
@DeliangFan DeliangFan changed the title Enable tf-operator tests in v1.2-branch #1355 Enable tf-operator tests in v1.2-branch #1355 Aug 17, 2021
@DeliangFan DeliangFan changed the title Enable tf-operator tests in v1.2-branch #1355 Enable tf-operator tests in v1.2-branch Aug 17, 2021
@DeliangFan DeliangFan mentioned this pull request Aug 17, 2021
Closed
gaocegege
gaocegege reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @Jeffwan @PatrickXYS

PatrickXYS
PatrickXYS approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@PatrickXYS PatrickXYS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
Hold for @Jeffwan approval

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DeliangFan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member

Jeffwan commented Aug 17, 2021 •
edited
Loading

Thanks @PatrickXYS for the review. LGTM

/unhold

@google-oss-robot google-oss-robot merged commit 30c45f6 into kubeflow:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@PatrickXYS PatrickXYS PatrickXYS approved these changes

@theofpa theofpa Awaiting requested review from theofpa

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

Assignees

@PatrickXYS PatrickXYS

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DeliangFan @google-oss-robot @Jeffwan @gaocegege @PatrickXYS