Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tf-operator tests in all-in-one-operator branch #951

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Jul 5, 2021

Which issue is resolved by this Pull Request:
Resolves #kubeflow/training-operator#1291

Description of your changes:
Enable prow test for tf-operator all-in-one-operator branch

/assign @PatrickXYS @theofpa
/cc @zw0610

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

@google-cla google-cla bot added the cla: yes label Jul 5, 2021
@Jeffwan Jeffwan changed the title Enabled tf-operator tests on all-in-one-operator branch Enable tf-operator tests on all-in-one-operator branch Jul 5, 2021
@Jeffwan Jeffwan changed the title Enable tf-operator tests on all-in-one-operator branch Enable tf-operator tests in all-in-one-operator branch Jul 5, 2021
@Jeffwan Jeffwan force-pushed the enable_tfjob_branch branch from dae2306 to a016b3e Compare July 5, 2021 21:10
@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 6, 2021

@PatrickXYS The change will be automatically applied to the prow config or needs manual process?

@PatrickXYS
Copy link
Member

@Jeffwan It will be automated updated then

/lgtm
/approve
/hold

Feel free to unhold

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 10, 2021

@PatrickXYS Thanks.

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 11, 2021

I will unblock merge when some partial refactor done in the repo

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 23, 2021

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants