Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh for minikube testing. #76

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Add ssh for minikube testing. #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a9b9f5
Add ssh for minikube testing.
jlewi Mar 21, 2018
8c28838
Log the file used to configure kubectl.
jlewi Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions images/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ RUN set -ex \
zip \
unzip \
gcc \
ssh \
python-dev \
python-setuptools \
python-pip \
Expand Down
17 changes: 11 additions & 6 deletions images/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,21 @@ all: build
# To build without the cache set the environment variable
# export DOCKER_BUILD_OPTS=--no-cache
build:
docker build ${DOCKER_BUILD_OPTS} -t $(IMG):$(TAG) .
docker tag $(IMG):$(TAG) $(IMG):latest
@echo Built $(IMG):$(TAG) and tagged with latest
docker build ${DOCKER_BUILD_OPTS} -t $(IMG):$(TAG) .
@echo Built $(IMG):$(TAG)

# Build but don't attach the latest tag. This allows manual testing/inspection of the image
# first.
push: build
gcloud docker -- push $(IMG):$(TAG)
gcloud docker -- push $(IMG):latest
@echo Pushed $(IMG) with :latest and :$(TAG) tags
gcloud docker -- push $(IMG):$(TAG)
@echo Pushed $(IMG) with :$(TAG) tags
# Tagging into a new project can be very slow but it appears to work.
gcloud container images add-tag --quiet $(IMG):$(TAG) $(RELEASE_WORKER):$(TAG) --verbosity=info
echo created $(RELEASE_WORKER):$(TAG)

push-latest: push
gcloud container images add-tag --quiet $(IMG):$(TAG) $(IMG):latest --verbosity=info
echo created $(IMG):latest
# Tagging into a new project can be very slow but it appears to work.
gcloud container images add-tag --quiet $(RELEASE_WORKER):$(TAG) $(RELEASE_WORKER):latest --verbosity=info
echo created $(RELEASE_WORKER):latest
1 change: 1 addition & 0 deletions py/kubeflow/testing/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ def load_kube_config(config_file=None, context=None,

if config_file is None:
config_file = os.path.expanduser(kube_config.KUBE_CONFIG_DEFAULT_LOCATION)
logging.info("Using Kubernetes config file: %s", config_file)

config_persister = None
if persist_config:
Expand Down