-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Daemonset API for GPU driver installing #538
Conversation
/hold |
Seems the stable version defination file still has problem:
|
fa0e3a5
to
2446a48
Compare
The above problem has been fixed and verified in the tfjob ci tests, that works fine now. /cc @jlewi @zhenghuiwang |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhenghuiwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #537
Since the API version is apps/v1, We should use
kubernetes.client.AppsV1Api
, instead ofkubernetes.client.ExtensionsV1beta1Api
https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/stable/nvidia-driver-installer/cos/daemonset-preloaded.yaml
This change is