-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use pipenv in image building dockerfile #36
Merged
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
87b0e90
use pipenv to install packages and remove requirements.txt
643eced
Merge branch 'master' into use-pipenv
jimexist e58af5d
Create an initial OWNERS file. (#50)
jlewi b6f0f91
Upgrade Argo so we can use DAGs. (#51)
jlewi 0377b32
Push the CI worker image to kubeflow-releasing for use in our release…
jlewi 6b4e974
change testing-argo.kubeflow.io to testing-argo.kubeflow.org (#57)
jimexist 6274a7d
Fix Lun-kai github username (#59)
abdd843
change test cluster to kubeflow-ci (#61)
lluunn 80c3edd
fix argo uri (#62)
jimexist 7b3a7cf
Fix typo in README (#63)
dca991b
upgrade ksonnet from 0.8 to 0.9 for testing image (#64)
lluunn facf8e5
run ks upgrade (#66)
lluunn 5ccc9ae
Fix Dockerfile for testing image (#65)
lluunn 3aef9f0
Print ksonnet version in tests (#67)
9c80289
Add jsonnet to test-worker (#68)
9f70d54
make waiting time configurable (#69)
lluunn 5099377
fix up
8738094
Merge branch 'master' into use-pipenv
c898d9c
Merge branch 'master' into use-pipenv
jimexist 9a3ed36
fix pylint issues
jimexist 01bb4bc
remove extra line
jimexist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,6 @@ | |
import os | ||
import re | ||
import subprocess | ||
import tempfile | ||
import time | ||
import urllib | ||
import yaml | ||
|
@@ -31,7 +30,7 @@ def run(command, cwd=None, env=None, polling_interval=datetime.timedelta(seconds | |
"""Run a subprocess. | ||
|
||
Any subprocess output is emitted through the logging modules. | ||
|
||
Returns: | ||
output: A string containing the output. | ||
""" | ||
|
@@ -47,7 +46,7 @@ def run(command, cwd=None, env=None, polling_interval=datetime.timedelta(seconds | |
lines.append("{0}={1}".format(k, env[k])) | ||
logging.info("Running: Environment:\n%s", "\n".join(lines)) | ||
|
||
log_file = None | ||
# log_file = None | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you just delete this line? |
||
|
||
process = subprocess.Popen( | ||
command, cwd=cwd, env=env, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this get used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is used in https://github.com/kubeflow/testing/pull/36/files#diff-475e714b0c3678141c59dab9961e8841R103