Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and links in several docs #853

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Fix typos and links in several docs #853

merged 1 commit into from
Apr 1, 2020

Conversation

huskysun
Copy link
Contributor

@huskysun huskysun commented Apr 1, 2020

Trivial fixes on typos, links and formats in several docs.

@huskysun
Fix typos and links in several docs
b608000 
Trivial fixes on typos, links and formats in several docs.
liyinan926
liyinan926 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liyinan926 liyinan926 merged commit 8a4a991 into kubeflow:master Apr 1, 2020
@huskysun huskysun deleted the doc-fixes branch April 1, 2020 20:58
@huskysun huskysun restored the doc-fixes branch April 2, 2020 02:03
@huskysun huskysun deleted the doc-fixes branch April 2, 2020 02:04
@huskysun
Copy link
Contributor Author

huskysun commented Apr 2, 2020

Hi @liyinan926, sorry I am just curious that when you merge the PR, did you use "Squash and Merge"? Will that change the committer's information? I wanted to ask since when I made the PR I was using my corporate email address, but once it is merged for some reason it changed to my personal email address. This also happened to another PR I created that you merged today. Do you know anything about this? Thanks!

@liyinan926
Copy link
Collaborator

Yes, "Squash and Merge" is the only enabled merge method for this repo. Please make sure you set user.email in your Git setting correctly when creating commits.

@huskysun
Copy link
Contributor Author

huskysun commented Apr 2, 2020 •
edited
Loading

No, I actually set user.email correctly when I made the commits. Seems like this is a known issue that, if use "Squash and Merge", GitHub will simply ignore author name and author email (as set with user.name and user.email) and change them into your GitHub account's profile name and primary email. 🤦‍♂️
isaacs/github#1368 (comment)

@huskysun huskysun restored the doc-fixes branch April 3, 2020 15:15
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
@huskysun
Fix typos and links in several docs (kubeflow#853)
58e35ec 
Trivial fixes on typos, links and formats in several docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyinan926 liyinan926 liyinan926 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huskysun @liyinan926