Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed docker image tag and updated chart docs #1969

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Apr 13, 2024

now docker images are published with 'preview' tag. changed it to a app version from Chart.yaml

@vara-bonthu
Copy link
Contributor

@AndrewChubatiuk , it looks like the PR description is missing. Could you please provide more details to help us review your changes effectively?

Purpose of the Change: Why is this change necessary?
Problem Addressed: What issue are you encountering that this change resolves?
Solution: How does this change solve the problem?
Impact of Not Merging: What would be the consequences if this PR is not merged?
Existing Workarounds: Is there a current workaround for this issue, and if so, what are its drawbacks?

Thank you for contributing, and we look forward to your detailed response!

@AndrewChubatiuk
Copy link
Contributor Author

updated

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewChubatiuk, vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 39b79d7 into kubeflow:master Apr 14, 2024
6 of 7 checks passed
vara-bonthu pushed a commit to vara-bonthu/spark-on-k8s-operator that referenced this pull request Apr 14, 2024
vara-bonthu pushed a commit to vara-bonthu/spark-on-k8s-operator that referenced this pull request Apr 14, 2024
google-oss-prow bot pushed a commit that referenced this pull request Apr 14, 2024
* Issue templates are added to the repo

Signed-off-by: Vara Bonthu <[email protected]>

* removed Google CLA requirement

Signed-off-by: Vara Bonthu <[email protected]>

* Updated ghcr.io registry references in the workflow

Signed-off-by: Vara Bonthu <[email protected]>

* Added Pull request template

Signed-off-by: Vara Bonthu <[email protected]>

* Updated Main README.md with Kubeflow header and new Slack channel link

Signed-off-by: Vara Bonthu <[email protected]>

* Removed the License header and it will be replaced with Kubeflow guidelines

Signed-off-by: Vara Bonthu <[email protected]>

* Revert "Removed the License header and it will be replaced with Kubeflow guidelines"

This reverts commit b892f5c.

Signed-off-by: Vara Bonthu <[email protected]>

* Readme line revert for gcp docs

Signed-off-by: Vara Bonthu <[email protected]>

* pre-commit run -a updates

Signed-off-by: Vara Bonthu <[email protected]>

* fixed the helm lint issue by upgrading the Helm chart version

Signed-off-by: Vara Bonthu <[email protected]>

* fixed docker image tag and updated chart docs (#1969)

Signed-off-by: Andrew Chubatiuk <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>

* rebase from master

Signed-off-by: Vara Bonthu <[email protected]>

---------

Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Andrew Chubatiuk <[email protected]>
Co-authored-by: Andrii Chubatiuk <[email protected]>
peter-mcclonski pushed a commit to TechnologyBrewery/spark-on-k8s-operator that referenced this pull request Apr 16, 2024
Signed-off-by: Andrew Chubatiuk <[email protected]>
Signed-off-by: Peter McClonski <[email protected]>
peter-mcclonski pushed a commit to TechnologyBrewery/spark-on-k8s-operator that referenced this pull request Apr 16, 2024
* Issue templates are added to the repo

Signed-off-by: Vara Bonthu <[email protected]>

* removed Google CLA requirement

Signed-off-by: Vara Bonthu <[email protected]>

* Updated ghcr.io registry references in the workflow

Signed-off-by: Vara Bonthu <[email protected]>

* Added Pull request template

Signed-off-by: Vara Bonthu <[email protected]>

* Updated Main README.md with Kubeflow header and new Slack channel link

Signed-off-by: Vara Bonthu <[email protected]>

* Removed the License header and it will be replaced with Kubeflow guidelines

Signed-off-by: Vara Bonthu <[email protected]>

* Revert "Removed the License header and it will be replaced with Kubeflow guidelines"

This reverts commit b892f5c.

Signed-off-by: Vara Bonthu <[email protected]>

* Readme line revert for gcp docs

Signed-off-by: Vara Bonthu <[email protected]>

* pre-commit run -a updates

Signed-off-by: Vara Bonthu <[email protected]>

* fixed the helm lint issue by upgrading the Helm chart version

Signed-off-by: Vara Bonthu <[email protected]>

* fixed docker image tag and updated chart docs (kubeflow#1969)

Signed-off-by: Andrew Chubatiuk <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>

* rebase from master

Signed-off-by: Vara Bonthu <[email protected]>

---------

Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Andrew Chubatiuk <[email protected]>
Co-authored-by: Andrii Chubatiuk <[email protected]>
Signed-off-by: Peter McClonski <[email protected]>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
* Issue templates are added to the repo

Signed-off-by: Vara Bonthu <[email protected]>

* removed Google CLA requirement

Signed-off-by: Vara Bonthu <[email protected]>

* Updated ghcr.io registry references in the workflow

Signed-off-by: Vara Bonthu <[email protected]>

* Added Pull request template

Signed-off-by: Vara Bonthu <[email protected]>

* Updated Main README.md with Kubeflow header and new Slack channel link

Signed-off-by: Vara Bonthu <[email protected]>

* Removed the License header and it will be replaced with Kubeflow guidelines

Signed-off-by: Vara Bonthu <[email protected]>

* Revert "Removed the License header and it will be replaced with Kubeflow guidelines"

This reverts commit b892f5c.

Signed-off-by: Vara Bonthu <[email protected]>

* Readme line revert for gcp docs

Signed-off-by: Vara Bonthu <[email protected]>

* pre-commit run -a updates

Signed-off-by: Vara Bonthu <[email protected]>

* fixed the helm lint issue by upgrading the Helm chart version

Signed-off-by: Vara Bonthu <[email protected]>

* fixed docker image tag and updated chart docs (kubeflow#1969)

Signed-off-by: Andrew Chubatiuk <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>

* rebase from master

Signed-off-by: Vara Bonthu <[email protected]>

---------

Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Andrew Chubatiuk <[email protected]>
Co-authored-by: Andrii Chubatiuk <[email protected]>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Issue templates are added to the repo

Signed-off-by: Vara Bonthu <[email protected]>

* removed Google CLA requirement

Signed-off-by: Vara Bonthu <[email protected]>

* Updated ghcr.io registry references in the workflow

Signed-off-by: Vara Bonthu <[email protected]>

* Added Pull request template

Signed-off-by: Vara Bonthu <[email protected]>

* Updated Main README.md with Kubeflow header and new Slack channel link

Signed-off-by: Vara Bonthu <[email protected]>

* Removed the License header and it will be replaced with Kubeflow guidelines

Signed-off-by: Vara Bonthu <[email protected]>

* Revert "Removed the License header and it will be replaced with Kubeflow guidelines"

This reverts commit b892f5c.

Signed-off-by: Vara Bonthu <[email protected]>

* Readme line revert for gcp docs

Signed-off-by: Vara Bonthu <[email protected]>

* pre-commit run -a updates

Signed-off-by: Vara Bonthu <[email protected]>

* fixed the helm lint issue by upgrading the Helm chart version

Signed-off-by: Vara Bonthu <[email protected]>

* fixed docker image tag and updated chart docs (kubeflow#1969)

Signed-off-by: Andrew Chubatiuk <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>

* rebase from master

Signed-off-by: Vara Bonthu <[email protected]>

---------

Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Andrew Chubatiuk <[email protected]>
Co-authored-by: Andrii Chubatiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants