PyTorch Operator: Move manifests development upstream #320
Conversation
As part of the work of wg-manifests for 1.3 (kubeflow/manifests#1735), we are moving manifests development in upstream repos. This gives the application developers full ownership of their manifests, tracked in a single place. This commit copies the manifests for application `PyTorch Operator` from path `apps/pytorch-job/upstream` of kubeflow/manifests to path `manifests` of the upstream repo (https://github.com/kubeflow/pytorch-operator). Signed-off-by: Yannis Zarkadas <[email protected]>
|
@terrytangyuan is there any work remaining for merging the PR? |
|
I'd defer to @johnugeorge and others from @kubeflow/wg-training-leads to confirm since I didn't author these manifests originally. |
There was a problem hiding this comment.
Thank you @yanniszark.
Should we also delete the current manifests and update the CI/CD ?
| metadata: | ||
| labels: | ||
| name: pytorch-operator | ||
| annotations: |
There was a problem hiding this comment.
Why do we disable istio for the PyTorchJob controller ?
| @@ -0,0 +1,3 @@ | |||
| pytorchDefaultImage=null | |||
There was a problem hiding this comment.
I think we can remove this file
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, terrytangyuan, yanniszark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue Resolved
Resolves: #318
Umbrella issue: kubeflow/manifests#1740
Description
As part of the work of wg-manifests for 1.3
(kubeflow/manifests#1735), we are moving manifests
development in upstream repos. This gives the application developers full
ownership of their manifests, tracked in a single place.
This PR copies the manifests for application
PyTorch Operatorfrom path
apps/pytorch-job/upstreamof kubeflow/manifests to pathmanifestsof the upstream repo (https://github.com/kubeflow/pytorch-operator).cc @kubeflow/wg-training-leads